Repository navigation
feat(workspace): add worker roster state rings, scope, now focus, and progress pills - #9197
loopx-agent wants to merge 2 commits into
Conversation
… progress pills Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · Gemini · Google · self_reported
Request changes conclusion (author-owned PR; GitHub blocks formal self-review)
动机 / Motivation
受影响对象:在 Dashboard 个人工作台中管理多 Worker Goal 概览、多接收方交办协作卡片、Agent 工作目录与原会话、以及 Goal 详情抽屉的操作者,以及评审该 PR 首屏视觉证据的维护者。
前后场景对比:改动前:概览、交办卡片、Agent 目录与绑定会话缺少统一的四态环形指示、Scope 标签、单行 Now 焦点与进度计数器,且日志或 JSON 噪声易污染焦点文案;改动后:协作状态派生集中到 collaboration-status.ts,各视图共享四态徽章与格式化进度,但在当前 exact head 实测渲染中,概览顶栏以整行宽度堆叠 worker 芯片将主工作列表挤出 1280×800 与 390×844 首屏,多接收方桌面汇总网格把 Now 挤压至单字截断,且 PR 正文 Goal 详情截图返回 HTTP 404。
可观测预期结果:在 dashboard 个人工作台本地引入 4 态 Worker Roster 状态机、ANSI/JSON/堆栈清洗与 [done/total] 进度展示,保持零后端 schema 与枚举变更;实测单测与打包构建通过,但多 Worker 概览首屏可读性与多接收方桌面摘要出现视觉回退。
本轮明确不做:不修改 Python 后端契约、全局 Todo/Run/RequestControl schema 或自动执行策略,也不重做工作流与协作控制器写回逻辑。
当前仍存在的缺口:1) GoalWorkspaceWork 概览芯片条占满整行并垂直堆叠且 Board/Map 切为 summaryOnly=false 展开完整列表,导致多 Worker 场景任务分组被挤出首屏;2) CollaborationCards 多接收方汇总行在 1280×800 桌面聊天栏单行网格下挤压 Now 文案至 Reply ...;3) PR 描述中 After Goal Details Drawer desktop 图片返回 HTTP 404,首屏视觉证据不完整;4) AttachedConversation 缺少 latestFocus 时两行状态文案重复(非阻塞 P2)。
不做此事的问题在于,此前个人工作台各面板各自拼接状态文字、缺少统一的四态可视化分级,终端噪声或 JSON 片段也容易直接泄漏到界面摘要行。本 PR 将派生逻辑收敛到单一前端模块并覆盖多处工作台视图,在代码分层上是一个清晰可审的局部增量;但首屏布局退化与截断问题使其在人口稠密(populated)场景下尚未达到合并标准。
改动思路 / Approach
整体架构与边界决策:纯派生状态机与展示原语仅限于 dashboard/features/personal-workspace 本地 12 个文件,不新增持久化字段或后端端点,整体拆分方向合适;当前需要修补的是消费侧 CSS 网格/芯片布局与 PR 截图证据,无需推翻核心派生模型。仅覆盖 personal-workspace 呈现层状态派生与组件布局(collaboration-status.ts, worker-roster.{tsx,css}, collaboration-card.{tsx,css}, goal-workspace-work.{tsx,css}, goal-agent-work-page.tsx, attached-agent-conversations.{tsx,css}, context-drawer.tsx 及 collaboration-status.test.mjs),不含后端写操作或存储结构变更。
在数据流上,PR 保持所有后端 HTTP/JSON 契约不变:
- 派生层收口(
collaboration-status.ts):定义封闭联合类型WORKER_ROSTER_STATES(needs_decision/working/lease_expired/waiting),分别针对CollaborationReadback+RequestControlView(deriveCollaborationCardStatus/deriveCollaborationRosterSummary)、Goal 维度聚合视图(deriveGoalWorkerRoster)与原会话绑定态(deriveAttachedWorkerStatus)完成纯函数派生;同时通过sanitizeFocusLine对展示层Now:文案清除 ANSI、JSON 行、命令与个人目录前缀。 - 复用原语组件(
worker-roster.tsx/worker-roster.css):提炼WorkerStateGlyph、WorkerStateBadge、WorkerScopeTag、WorkerProgressBadge、WorkerNowLine与GoalWorkerRosterStrip,复用现有--pw-*CSS 变量体系(check:css-custom-properties校验 44 份样式表、62 个令牌、0 未定义引用),未新增平行状态存储或后端 API。
flowchart LR
A["Typed Readbacks (Goal / Digest / Run / HostThread / RequestControl)"] --> B["collaboration-status.ts (4-state Roster + sanitizeFocusLine + ProgressCounter)"]
B --> C1["GoalWorkspaceWork Overview: pw-roster-chips (full-width rows -> P1 fold pushdown)"]
B --> C2["GoalWorkspaceWork Board/Map: summaryOnly=false -> P1 multi-line list pushdown"]
B --> C3["CollaborationCards Summary: 6-col desktop grid -> P1 Now truncation"]
B --> C4["ContextDrawer + GoalAgentWorkPage + AttachedConversation (reused primitives)"]
(说明:以上结构图基于 9197@0764b161e570faf0f4ab3769d8d77717597e5d97 源码追踪绘制,用作路径示意而非运行时测试证明。)
具体改动 / Changes
全部改动严格限定在 apps/presentation/dashboard/src/features/personal-workspace/ 下 12 个文件(git diff --numstat 合计 2,162 additions / 90 deletions,diff 总计 2,457 行;0 Python 或协议文件修改)。
关键代码讲解
deriveGoalWorkerRoster(apps/presentation/dashboard/src/features/personal-workspace/collaboration-status.ts#L524-L707):汇总agentLanes、registeredAgentIds、workerObservations、hostThreadActivity、digest.work.rows与实时WorkspaceRun,按pausedObs(needs_decision)> 过期租约/静态窗口且非活跃(lease_expired)> 实测运行(working)> 阻塞待办或人工注意力门(needs_decision)>waiting排序,并在coverageComplete不足时通过[N 待办]/[done/total]/[done/—]如实呈现未知总数而不伪造0。deriveCollaborationCardStatus(collaboration-status.ts#L321-L446)与CollaborationCards(collaboration-card.tsx#L158-L204):读取RequestControlView实时回读与CollaborationReadback,保持三步法进度[0..3/3]与原文控制面板语义,在多接收方场景下渲染顶部.pw-collab-roster-summary聚合栏,保留每张卡片独立的RequestControl操作权限。sanitizeFocusLine(collaboration-status.ts#L252-L263)与formatProgressCounter(#L265-L294):通过Array.from码点级截断(truncateCodePoints)避免中文与代理对字符截断乱码,过滤终端控制码、JSON 对象行、常见构建命令与测试异常堆栈以生成人类可读Now:焦点,不参与状态枚举判断。GoalWorkerRosterStrip(worker-roster.tsx#L57-L142)与GoalWorkspaceWork(goal-workspace-work.tsx#L243-L251):在summaryOnly模式下渲染.pw-roster-chips,否则展开.pw-roster-list(含完整WorkerNowLine)。在GoalWorkspaceWork中当lens === "owner"且有工作组时传summaryOnly={true},但切到Board/Map时切换为summaryOnly={false}。
规范对齐与准则映射
对照内部 UI 规范 docs/development/design.md#populated-page-review(基线提交 387a8ea7b404222aec95edf4e4a7c061f7ea0b29)与交付规范:
POPULATED_FIRST_SCREEN(高密度真实多条目页面首屏必须直接可见核心工作内容,不能被汇总头部或堆叠芯片挤出视口):not_met(在 4+ Worker 概览桌面/移动端及 Map 视角下触发首屏下推回退)。DESKTOP_SUMMARY_READABILITY(避免桌面端核心动态信息在窄格中被多余控件压到单字截断或无意义重复):not_met(桌面聊天栏.pw-collab-roster-now被单行六列网格压成"Reply ...";且AttachedConversation空闲态出现两行重复状态文字)。PR_VISUAL_EVIDENCE(提交前 PR 描述必须附带完整可用的前后视觉证据截图):not_met(After Goal Details Drawer desktop图片返回 HTTP 404)。TYPED_LOCAL_DERIVATION(零后端协议改动前提下复用既有 typed owner 与可访问性标签):implemented(GoalAgentWorkPage保留单一按钮可访问名称,collaboration-status.test.mjs6/6 与smoke:multi-recipient/request-control-browser-smoke均无破坏)。
对主干的风险 / Risks
发现清单(Findings)
-
[P1 · 阻塞] Goal Overview
.pw-roster-chips单列全宽堆叠且 Board/Map 切为展开清单,导致多 Worker 任务区被挤出首屏- 触发条件与路径:当 Goal 具有 4 个及以上 Worker 时,
GoalWorkspaceWork(goal-workspace-work.tsx#L243-L251)渲染<GoalWorkerRosterStrip summaryOnly={lens === "owner" && digest.work.groups.length > 0} />;worker-roster.css#L266-L290为.pw-roster-chips设置单列display: grid且.pw-roster-chip { width: 100%; }。 - 实测结果:在 PR 正文 1280×800 桌面图及实时 Playwright 截图中,4 个堆叠芯片把
.goal-owner-groups任务卡片整体压到 800px 视口最底缘甚至首屏之外(6 个 Worker 时 390×844 首屏被芯片占满);切换至关系图 / Map视图时因lens !== "owner"改为渲染带Now:的完整.pw-roster-list,进一步下推工作地图。 - 最小修复与复验:将
.pw-roster-chips改为横向流式换行条(display: flex; flex-wrap: wrap;且.pw-roster-chip { width: auto; }),同时在Board/Map视图也保留summaryOnly={true}或紧凑汇总行;重跑smoke:goal-workspace-craft-browser-smoke并检查 4+ Worker 1280×800 / 390×844 截图。
- 触发条件与路径:当 Goal 具有 4 个及以上 Worker 时,
-
[P1 · 阻塞]
CollaborationCards桌面端单行六列网格挤压Now:摘要至单字截断- 触发条件与路径:多接收方请求在 1280×800 桌面端的右侧约 560px 会话栏渲染
.pw-collab-roster-summary,collaboration-card.css#L29-L39定义grid-template-columns: 12px auto auto auto minmax(0, 1fr) auto;仅在@media (max-width: 640px)才折行。 - 实测结果:PR 正文桌面图与实时 Playwright 多接收方截图显示,长
Scope与[2/3]徽章占用绝大部分行宽,minmax(0, 1fr)内.pw-collab-roster-now被压缩为"Reply ..."单个单词截断(同数据在 390×844 折行模式下则显示完整)。 - 最小修复与复验:桌面窄容器及全宽场景同样让
.pw-collab-roster-now换至第二行全宽渲染(两行网格或与 640px 一致的 flex 换行),确保 1280×800 聊天面板中完整可读;重跑smoke:multi-recipient并更新桌面截图。
- 触发条件与路径:多接收方请求在 1280×800 桌面端的右侧约 560px 会话栏渲染
-
[P1 · 阻塞] PR 描述中 Goal 详情抽屉对比图片链接返回 HTTP 404
- 触发条件与路径:PR 正文视觉证据表
After Goal Details Drawer desktop链接(261624be-d8d2-4925-aa0f-d74ad9cd7838)实测返回HTTP/2 404 Not Found。 - 最小修复与复验:补传可访问的抽屉截图并确认所有 PR 正文图片 URL 返回 200。
- 触发条件与路径:PR 正文视觉证据表
-
[P2 · 非阻塞]
AttachedConversation空闲且缺少latestFocus时重复渲染近义状态- 位置与后果:
attached-agent-conversations.tsx#L539-L543在<p role="status">原会话可回复</p>下紧接<WorkerNowLine now={attachedStatus.now} />,deriveAttachedWorkerStatus回退输出"Now: 原会话空闲,可直接回复",存在轻度文案冗余。建议仅在存在latestFocus、模型运行态或异常态时展示WorkerNowLine。
- 位置与后果:
其他核验维度
- Scope Fit & 调用方:12 个文件均由当前
PersonalWorkspace生产页面直接消费(Overview、Board/Map、Agent 目录、AttachedConversation、CollaborationCards、ContextDrawer),无孤立未接入组件。 - Typed State Rule & Authority Semantics:
WorkerRosterState使用 TypeScriptas const封闭 4 态联集,状态分类完全基于类型化字段判定;isTerminalOrJsonNoiseLine正则仅清洗展示文案,不参与权威状态或控制流切换。无新增外部协议名称,未夸大子任务生命周期或合并授权语义。 - Default-Off Isolation & Behavior Disclosure:本轮属于
PersonalWorkspace既有看板视觉增强,无后端 feature flag,未改变既有RequestControl写入、只读来源拦截、归档权限与按钮可访问名;需注意collaboration-status.test.mjs目前需显式node --experimental-strip-types --test执行,尚未编入package.json的smoke:personal-workspace聚合脚本。 - 独立复验矩阵(均在干净检出
9197@0764b161e570faf0f4ab3769d8d77717597e5d97上执行):check:css-custom-properties:PASS(44 份样式表、62 个定义令牌、3902 处裸引用、0 未定义)npm --prefix apps/presentation/dashboard run build(tsc --noEmit && vite build && build:chat):PASScollaboration-status.test.mjs(node --no-warnings --experimental-strip-types --test):PASS(6/6 测试通过);smoke:agent-family/smoke:goal-work-browse(4/4)/smoke:goal-order/smoke:goal-activity/smoke:proposal-recency:PASS(注:直接通配运行*.test.mjs时,goal-work-browse.test.mjs与todo-completion-feedback.test.mjs因依赖 Vite SSR 编译入口报错,属脚本调用方式差异而非本 PR 引入退化;通过npm run smoke:goal-work-browse实测 4/4 通过)- 打包 Playwright 浏览器冒烟(
smoke:multi-recipient、request-control-browser-smoke、goal-workspace-craft-browser-smoke、attached-host-follow-up、goal-workspace-m2):PASS loopx check(12 文件,0 错误)与canary premerge(4/4 direct + 5/5 selected canaries,0 失败):PASS(工作树内无目标绑定 CQR 收据故quality_receipt_missing,属干净复审工作树环境预期)- 视觉抽查(PR 正文
00..07.png+ 实时 Playwright 截图):FAIL(上述 P1 × 3)
我的整体评价 / Verdict
- Long-horizon 影响(
preserved):未改动后端控制面、调度、配额或持久化模型,纯前端呈现与状态派生隔离在本地personal-workspace模块边界内,保留既有可维护性。 - User Experience 影响(
regression):虽然前端状态派生准确、类型严格、非视觉交互冒烟全部通过,但真实多 Worker 与多接收方场景下的首屏排布出现可感知的阅读障碍。视觉审查结论:在 1280×800 桌面端与 390×844 移动端实测截图及打包 Playwright 浏览器运行中发现三项呈现/证据阻塞问题:1)Goal Overview 顶部 .pw-roster-chips 纵向堆叠占满整行且 Board/Map 切换至 summaryOnly=false 展开多行清单,在 4+ Worker 场景将 .goal-owner-groups 主任务列表与工作地图挤出首屏;2)CollaborationCards 多接收方汇总条在 1280×800 桌面端沿用单行网格(12px auto auto auto minmax(0, 1fr) auto),导致 Now 列被挤压为单个单词截断(如 Reply ...);3)PR 描述内 After Goal Details Drawer desktop 图片资源返回 HTTP 404 Not Found。 未核验范围:PR 正文 After Goal Details Drawer desktop 链接返回 HTTP 404(已通过真实 Playwright 重新运行生成的 goal-detail-desktop.png 替代核验抽屉视图);ContextDrawer 运行摘要(run summary)及全部暗黑/纸张/粗野三主题同构快照未在此轮自动化 Playwright 中逐一截图比对。 - Observable Semantics & Code Volume:行为等价边界明确(零后端协议变化,旧有只读阻断、按钮名称与 RequestControl 写回语义均保持兼容);新增 761 行
collaboration-status.ts与 142 行worker-roster.tsx均承担统一复用职责,结构合理无需推倒重写,仅需针对性修复上述布局样式与视觉证据。 - 语义与词表归属:
WorkerRosterState与展示辅助文案严格保持为apps/presentation/dashboard/src/features/personal-workspace/内部局部类型(stays local),未触碰共享注册表或 RFC 双语门禁。 - 复审准入条件(Re-review Gate):作者推送修复以下三项的新 exact head 后再行复审:1)将 Overview 顶部
.pw-roster-chips改为紧凑横向多列折行并保证Board/Map不因展开列表下推主体;2)将CollaborationCards.pw-collab-roster-summary桌面端Now:改为不截断的第二行布局;3)修复 PR 正文全部截图链接返回 200 并补全最新 1280×800 / 390×844 对比图。
English verdict: REQUEST_CHANGES — Status derivation, CSS token hygiene, TypeScript/Vite builds, unit tests, and packaged Playwright behavioral smokes pass on 9197@0764b161e570faf0f4ab3769d8d77717597e5d97, but populated visual inspection fails on three blockers: full-width stacked overview worker chips and non-summary Board/Map header rows push primary task/map content below the first viewport, the desktop CollaborationCards 6-column grid crushes Now: text down to "Reply ...", and the PR body's Goal Details Drawer screenshot returns HTTP 404.
…top collaboration summary Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · Gemini · Google · self_reported
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
受影响对象:在 Dashboard 个人工作台中管理多 Worker Goal 概览、看板/关系图、多接收方交办协作卡片、Agent 工作目录、原会话以及 Goal 详情抽屉的操作者。
前后场景对比:改动前:个人工作台各卡片与列表缺少统一的四态环形指示、Scope 标签、单行 Now 焦点与进度计数器,长 CN/EN 标题或日志 JSON 噪声易影响扫视,上一版还存在概览芯片纵列挤出首屏与桌面多接收方 Now 被压至单字截断的问题;改动后(5789e163fb):状态派生集中于 collaboration-status.ts,概览芯片改为紧凑横向流式按钮且在看板/关系图同样保持 summaryOnly,桌面多接收方摘要统一将 Now 换行至第二行全宽展示,AttachedConversation 空闲无焦点时不再重复冗余提示,且 PR 正文 13 张前后对比图全部实测返回 HTTP 200。
可观测预期结果:在 personal-workspace 本地 12 个文件内交付四态 Worker Roster 状态环、Scope 标签、单行清洗后的 Now 焦点与诚实未知总数进度,零后端 schema 与枚举变更;6 个 Worker 概览首屏与桌面 1280×800 / 窄屏 390×844 多接收方摘要均完整可读且无横向溢出。
本轮明确不做:不修改 Python 后端契约、全局 Todo/Run/RequestControl schema 或自动执行策略,也不调整共享语义词表注册表。
当前仍存在的剩余边界:ContextDrawer 运行摘要(run summary)实时渲染截屏与 paper/brutal 主题整页视觉对照未另行逐张抓拍,且 collaboration-status.test.mjs 尚需显式 node --experimental-strip-types --test 触发而非自动纳入 smoke:personal-workspace 聚合脚本(均不阻塞本 PR)。
不做此事的问题在于,此前个人工作台多视图各自格式化状态摘要,既缺少统一的风险分级与进度指示,也容易将终端控制序列或 JSON 调试行透传到用户界面;而若保留上一版 0764b16 的全宽芯片与桌面单行网格,多 Worker 场景反而会被挤压到首屏之外。本轮 5789e16 在不触动任何后端存储的前提下精准修复了全部 P1 视觉阻断与 P2 冗余文案,构成可独立合并的高质量 UI 交付增量。
改动思路 / Approach
整体架构与边界决策:纯派生状态机与展示原语严格隔离在 dashboard/features/personal-workspace 本地 12 个文件,不新增后端字段或状态写回逻辑;5789e163fb 在复用同一套派生核心的基础上仅用局部 CSS 与条件渲染修补就消除了全部 P1 排版回归。严格限定为 personal-workspace 呈现层状态派生、可访问性优化与布局样式(collaboration-status.ts, worker-roster.{tsx,css}, collaboration-card.{tsx,css}, goal-workspace-work.{tsx,css}, goal-agent-work-page.tsx, attached-agent-conversations.{tsx,css}, context-drawer.tsx 与 collaboration-status.test.mjs),零后端或协议变更。
- 零副作用纯函数派生(
collaboration-status.ts):定义模块局部封闭联合类型WORKER_ROSTER_STATES(needs_decision/working/lease_expired/waiting),分别覆盖交办卡片(deriveCollaborationCardStatus/deriveCollaborationRosterSummary)、Goal 聚合队列(deriveGoalWorkerRoster)与绑定原会话(deriveAttachedWorkerStatus)。其中新增的includeFallbackNow?: boolean让AttachedConversation在空闲且无latestFocus时返回空串,从源头避免与<p role="status">重复。 - 紧凑流式原语与响应式一致性(
worker-roster.tsx/worker-roster.css/collaboration-card.css):在summaryOnly芯片条中将<button className="pw-roster-chip pw-roster-chip-btn">直接作为紧凑按钮载体(附完整aria-label与title提示Scope/Now:),GoalWorkspaceWork全视角统一保持summaryOnly,而.pw-collab-roster-list li在桌面与移动端统一启用flex-wrap: wrap+order: 10; flex: 1 0 100%的.pw-collab-roster-now第二行布局。
flowchart LR
A["Typed Readbacks (Goal / Digest / Run / HostThread / RequestControl)"] --> B["collaboration-status.ts (4-state Roster + sanitizeFocusLine + includeFallbackNow)"]
B --> C1["GoalWorkspaceWork (By owner / Board / Map): summaryOnly flex chips -> tasks/map above fold"]
B --> C2["CollaborationCards Summary: flex-wrap desktop + mobile -> full-width row-2 Now"]
B --> C3["AttachedConversation (includeFallbackNow=false) -> no duplicate idle line"]
B --> C4["ContextDrawer + GoalAgentWorkPage (reused WorkerRoster primitives)"]
(说明:以上结构图基于 9197@5789e163fbe1bc95c8f865f84e60c45172e1d2ee 源码链路绘制,仅作架构示意,不替代下述实测证据。)
具体改动 / Changes
全部改动严格限定在 apps/presentation/dashboard/src/features/personal-workspace/ 下 12 个文件(git diff --numstat 合计 2,162 additions / 92 deletions,diff 总计 2,494 行;0 Python 或协议改动)。相对上一版 0764b161e5 的增量修订精准落在 attached-agent-conversations.tsx、collaboration-card.css、collaboration-status.ts、collaboration-status.test.mjs、goal-workspace-work.tsx 与 worker-roster.{tsx,css}。
关键代码讲解
deriveGoalWorkerRoster(apps/presentation/dashboard/src/features/personal-workspace/collaboration-status.ts#L525-L708):合并agentLanes、registeredAgentIds、workerObservations、hostThreadActivity、digest.work.rows与实时WorkspaceRun;按pausedObs> 过期租约/静态窗口且非活跃 > 实测运行 > 阻塞门 >waiting归类,并在coverageComplete不足时用[N 待办]/[done/—]如实展示未知总数而不伪造 0。GoalWorkerRosterStrip(worker-roster.tsx#L57-L159&worker-roster.css#L265-L357)与GoalWorkspaceWork(goal-workspace-work.tsx#L244-L253):summaryOnly模式以.pw-roster-chips(display: flex; flex-wrap: wrap) 渲染紧凑横向芯片;存在活跃对话入口时整体渲染为无障碍<button className="pw-roster-chip pw-roster-chip-btn">(无额外内嵌小按钮挤压行宽),GoalWorkspaceWork对By owner/Board/Map一致传递summaryOnly,实测 6 个 Worker 在 1280×800 与 390×844 下任务分组与工作地图均保持在首屏内。CollaborationCards(collaboration-card.tsx#L158-L204&collaboration-card.css#L29-L76)与deriveCollaborationCardStatus(collaboration-status.ts#L322-L447):移除仅在@media (max-width: 640px)才折行的差异化样式,让.pw-collab-roster-list li在全视口均以flex-wrap: wrap配合.pw-collab-roster-now { flex: 1 0 100%; order: 10; }渲染,彻底解决 1280×800 右侧窄栏截断问题;同时保留每张卡片独立的RequestControl编辑与三步进度[step/3]。deriveAttachedWorkerStatus(collaboration-status.ts#L710-L766)与AttachedConversation(attached-agent-conversations.tsx#L514-L544):新增includeFallbackNow = true默认参数(单元测覆盖),AttachedConversation传includeFallbackNow: false,确保缺少latestFocus时仅在存在真实回合焦点的情况输出WorkerNowLine,实测attached-codex-conversation-desktop.png无冗余行。
规范对齐与准则映射
对照内部 UI 规范 docs/development/design.md#populated-page-review(基线提交 387a8ea7b404222aec95edf4e4a7c061f7ea0b29)与交付规范:
POPULATED_FIRST_SCREEN(高密度多 Worker 概览、看板与关系图首屏必须直接露出任务/地图主体):implemented(worker-roster.css、goal-workspace-work.tsx;经 1280×800 与 390×844 Playwright 实时截图与goal-workspace-craft-browser-smoke验证)。DESKTOP_SUMMARY_READABILITY(桌面多接收方摘要与绑定会话无单字截断及无意义重复):implemented(collaboration-card.css、attached-agent-conversations.tsx、collaboration-status.ts;经06.png、multi-recipient/conversation.png与attached-codex-conversation-desktop.png核验)。PR_VISUAL_EVIDENCE(PR 正文全部截图链接有效且反映最新 exact head):implemented(正文 13 张前后对比图全部通过curl实测返回 HTTP 200 并经视觉检查)。TYPED_LOCAL_DERIVATION(零后端修改前提下基于现有 typed readbacks 完成状态派生):implemented(collaboration-status.ts;经collaboration-status.test.mjs6/6 与 12 文件限定git diff --numstat验证)。
对主干的风险 / Risks
发现清单(Findings)
在 exact head 5789e163fbe1bc95c8f865f84e60c45172e1d2ee 上 无阻塞性问题(No blocking findings),此前三项 P1 阻断与一项 P2 冗余均已验证关闭:
- 原 P1-1(Overview / Map 首屏下推):已由横向流式
.pw-roster-chips+ 全视角summaryOnly修复并在overview-populated-desktop.png(6 Workers +未分配+worker-0分组可见)、overview-populated-mobile.png(6 Workers + 2 个待办可见)和goal-craft-map-desktop.png(完整地图可见)验证闭合。 - 原 P1-2(桌面多接收方 Now 截断):已由跨视口一致的两行 flex 布局修复并在
06.png与multi-recipient/conversation.png确认完整可读。 - 原 P1-3(PR 截图 404):13/13 PR 描述图片 URL 已验证均返回 HTTP 200 且匹配
5789e163fb。 - 原 P2(AttachedConversation 重复空闲状态):已通过
includeFallbackNow: false消除并在attached-codex-conversation-desktop.png确认。
残余风险与最主要未验证项:ContextDrawer 的 Run 摘要渲染与非默认主题(paper、brutal)整页截屏未另行逐张抓拍(已由全套 --pw-* CSS 令牌静态检查与源码覆核兜底);此外 collaboration-status.test.mjs 目前作为显式 Node --experimental-strip-types --test 命令通过,后续可按需接入 package.json 的 smoke:personal-workspace 聚合入口。
其他核验维度与独立复验矩阵
- Scope Fit / Typed State Rule / Authority Semantics:12 个修改文件全部由生产路由直接消费;
WORKER_ROSTER_STATES为类型化 4 态封闭联合类型,isTerminalOrJsonNoiseLine正则仅过滤显示层Now:文本且不参与状态机或权限判定;无新增外部协议名称或越权语义。 - Default-Off Isolation & Behavior Disclosure:无后端 feature flag;保留既有
RequestControl写入闭环、只读隔离与旧按钮可访问性契约;smoke:goal-work-browse需经npm run编译入口运行(已独立实测 4/4 通过,不同于原始通配node --test *.test.mjs)。 - 独立复验结果(均在干净检出
9197@5789e163fbe1bc95c8f865f84e60c45172e1d2ee上完整执行):npm --prefix apps/presentation/dashboard run check:css-custom-properties:PASS(44 份样式表、62 个定义令牌、3897 处裸引用 / 1972--pw-*、0 未定义引用)npm --prefix apps/presentation/dashboard run build(tsc --noEmit && vite build && npm run build:chat):PASS- Node 单元测试(
collaboration-status.test.mjs、font-token.test.mjs、workspace-theme.test.mjs、personal-workspace-contract.test.mjs):PASS(12/12 通过,其中collaboration-status.test.mjs6/6) - Workspace 专项冒烟(
smoke:agent-family、smoke:goal-work-browse4/4、smoke:goal-order3/3 + invariants、smoke:goal-activity、smoke:proposal-recency):PASS - 打包与浏览器 Playwright 冒烟(
smoke:multi-recipientrecipient_count=2 / additional_browser_writes=0、request-control-browser-smoke、goal-workspace-craft-browser-smoke、attached-host-follow-up、goal-workspace-m2nodeCount=200 / withinBudget=true):PASS loopx check --scan-path apps/presentation/dashboard/src/features/personal-workspace:PASS(0 errors, 0 warnings, 5 checks)loopx canary premerge --from-git-diff --git-diff-base origin/main:PASS(status: passed,merge_gate_passed: true,4/4direct checks +5/5selected catalog canaries,0failures,manual_hold_count: 0)- 视觉复验(13/13 PR 描述截图 HTTP 200 + 实机重跑 Playwright 输出图):PASS
我的整体评价 / Verdict
- Long-horizon 影响(
preserved):完全维持后端控制平面、存储格式、调度、配额与协议零变动,新增状态派生模块结构清晰、易测试且可局部可逆回退。 - User Experience 影响(
improved):在 5789e16 上兼具统一四态语义清晰度、首屏高密度可扫视性与完整可读的Now:焦点,无阻塞回归。视觉审查结论:在 5789e16 重新核验全部 13 张 HTTP 200 PR 对比图及本机重跑生成的实时 Playwright 截图:1)1280×800 与 390×844 6-Worker Goal Overview(overview-populated-desktop.png、overview-populated-mobile.png)中,横向折行 .pw-roster-chips 与 Map summaryOnly(goal-craft-map-desktop.png)均保持任务分组与工作地图清晰位于首屏折线之上且零横向溢出;2)CollaborationCards 桌面端(06.png 与 multi-recipient/conversation.png)与 390px 窄屏(08.png)均将 .pw-collab-roster-now 独立置底全宽显示,彻底消除 Reply ... 单字截断;3)AttachedConversation(attached-codex-conversation-desktop.png)空闲无 latestFocus 时不再重复输出同义 Now 行;4)Goal Details Drawer 与 Agent Work Directory(10.png、12.png)均完整可访问且信息清晰。 未核验范围:ContextDrawer 单次 Run 摘要视图未另行生成独立静态截图(已读 TSX 调用路径),paper / brutal 主题的逐页整图视觉回归仅通过 check:css-custom-properties(44 份样式表、0 未定义变量)与源码检查覆核。 - Observable Semantics & Code Volume:行为等价边界经实测成立(
intentional_change_validated:展示层增补徽章、芯片与折行焦点,所有原有操作与只读语义保持一致);2,162+ / 92- 的改动集中在可复用纯函数(766L)、原语(159L)、样式(587L Delta)与单测(340L),比例合理无需额外拆分。 - 语义与词表归属:
WorkerRosterState与本地标签严格留在apps/presentation/dashboard/src/features/personal-workspace/(stays local),未触碰共享语义注册表或 RFC 双语门禁。 - Exact-head 新鲜度与结论:全部检查均针对
9197@5789e163fbe1bc95c8f865f84e60c45172e1d2ee独立完成,同意合入。
English verdict: APPROVE — Verified cleanly at exact head 9197@5789e163fbe1bc95c8f865f84e60c45172e1d2ee: all three prior P1 layout/evidence blockers and the P2 duplicate idle line are resolved across both 13/13 HTTP-200 PR captures and live packaged Playwright screenshots, CSS custom properties (44 stylesheets, 0 undefined), dashboard build, 12/12 unit tests, 5 workspace smokes, 5 Playwright browser smokes, loopx check (0 errors), and canary premerge (4/4 direct + 5/5 selected, 0 failures) all pass.
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, xhigh)
Request changes conclusion (author-owned PR; GitHub blocks formal self-review)
评审精确提交 5789e163fbe1bc95c8f865f84e60c45172e1d2ee,merge base 202d7bdb054b001cf002c3bdb83beb5012f21ccd。与核验时主干 de61cfe6a35a22a236d88e5e8a930428929d10d2 可干净整合。
- [P2] 交办回执不证明执行或租约到期。 没有执行事实的 queued conclusion 显示执行中;送达未核验显示租约过期。同一画面详情仍明确待送达和请确认原记录。 需要已观察的执行事实才标执行中,需要实际租约证据才标租约过期。只有交办回执的场景继续显示既有待送达或待核验事实。 候选位置
- [P2] 不完整任务列表不产生确定的 Worker 分母。 部分读取只载入一条已完成和一条开放任务。总 Goal 已知 10/33,但 Worker 显示 [1/2],其完整任务数并未返回。 按 Worker 的确定分母需要已证明完整覆盖。覆盖未知时显示已观测项数或不带分母的进度,运行步数则使用自身独立的完整度。 候选位置
动机 / Motivation
管理多人 Goal 或查看交办的读者,需要直接判断谁在执行、谁在等人,以及进度数字的覆盖范围。 基线已显示接收判断、送达结果及任务列表覆盖,但没有统一的 Worker 徽章与按人进度。 候选把同一 roster 组件铺到 Goal 概览、协作卡、Agent 目录、绑定会话和抽屉,收敛原视觉分散状态。 本轮限工作台呈现,既有写入、请求控制、后端 schema 与执行调度不在变更范围。 发布后可能使读者等待一个实际上没有运行的 Worker,或把待验收的回执误当成失去租约,还会把部分清单误读成完成率。
改动思路 / Approach
既有 typed readback 是状态权威,前端可以归并和格式化但不能据接受或未知态新造执行和租约事实。 本轮从现有 typed readback 比较工作台渲染与可达性。 修复可以沿现有 owner 完成。保留前一轮已修的紧凑概览和可访问详情。同头 Gemini 批准确认了布局修复,本轮独立反例核对的是状态证据和不完整分母。旧的抽屉图片链接现可加载。390px 上长 Now 在汇总仍会省略,原交办详情可展开读回。
具体改动 / Changes
全量差异 12 个文件,新增 2162 行、删除 92 行。规范依据是 docs/development/design.md 在 202d7bdb054b001cf002c3bdb83beb5012f21ccd 的版本,并核对相邻的 docs/development/frontend-delivery.md。固定依据 · 相邻交付规则
- 状态证据保真。 对应上文反例,待修。
- 部分覆盖可见。 对应上文反例,待修。
- 首屏与原详情。 下文列出已执行检查。
读回派生。 collaboration-status.ts 统一摘要清洗、四态映射、scope 与分子分母语义;配套单测覆盖关联字段。搭建没有执行租约的实际渲染反例后,发现概念被合并。
共享组件。 worker-roster.tsx/css 提供紧凑芯片、状态环、Scope、Now 和进度,CollaborationCard 保留每个接收方的单独概要和一次详情控制。
跨视图。 概览和三种工作视图保留 summaryOnly,Agent 目录和附属会话显示相关状态,Goal/Run 抽屉使用同源派生。旧的空闲重复通过 includeFallbackNow=false 处理。
关键代码讲解
deriveCollaborationCardStatus。共用的交办状态派生将回执缺失或采用映成租约或执行状态。 精确提交deriveGoalWorkerRoster。汇总 Goal、Host、运行和 Todo 的可用快照并计算进度。 精确提交GoalWorkerRosterStrip。用四态图示、scope 和进度渲染紧凑头或完整列表。 精确提交CollaborationCards。每个接收方保留独立详情,同时提供共同的轻量汇总。 精确提交GoalWorkspaceWork。按负责人、Board 与 Map 共用紧凑 roster。 精确提交
对主干的风险 / Risks
精确提交 11 项 dashboard 测试、44 份样式表 token 检查、生产前端构建与标准 premerge 4+5 通过。整合树的前端构建以及 7 项状态/主题检查通过。当前 main 与整合树在未触及的 personal-workspace-contract.test.mjs:743 同样失败,断言均为历史执行说明应附于 ContextHelp,归于两树相同的研究工作台路径。 同一真实组件和合成读回在桌面及 390px 显示相同的两个语义反例。审查通过详情的键盘操作证实原题只读信息仍然可达。 用 Vite 的合成数据实际渲染候选组件,不借用用户或生产 Goal。发布包的 real backend 结果来自作者,本地独评没有重复部署。 无持久化、执行或授权变化。发生变化的是操作者按默认界面看到的 Worker 状态和进度,错误语义在普通打开时即可遇到。
我的整体评价 / Verdict
REQUEST_CHANGES。 修复后沿相同入口复验。局部桌面和手机组件在已测视口都保持紧凑,但状态和数字会误导读者。 独立视觉检查限这组真实组件的合成输入;完整 Goal 首屏、Map 和真实后端打包路径沿用作者证据,安装态仍待验收。
English verdict: REQUEST_CHANGES at 5789e16. The roster reports execution and lease expiry from delivery-only evidence, and gives partial task coverage a definite worker denominator. Compact desktop and narrow layouts rendered, but both semantic regressions remain.
Summary
Stream II Personal Workspace Collaboration Visualization UX (inspired by
/swarm×Stitch Loopworker roster clarity while keeping zero backend schema or enum churn):collaboration-status.ts+collaboration-status.test.mjs):needs_decision/working/lease_expired/waiting) strictly from existing typedCollaborationReadback,RequestControlView,WorkspaceGoal,GoalWorkspaceDigest,WorkspaceRun,GoalHostThreadActivity, and attached-session readbacks without inventing liveness or changing backend protocols.sanitizeFocusLineto strip ANSI sequences, JSON payloads, shell/stack telemetry, raw hashes, and timestamps into a crisp single-lineNow:live focus summary with surrogate-pair-safe truncation for long CN/EN titles.formatProgressCounter([done/total], preservingnull/unbounded counts honestly rather than fabricating zero).worker-roster.tsx/worker-roster.css):collaboration-card.tsx/collaboration-card.css): adds an aggregate Roster summary strip (counts+[concluded/total]+ per-recipient flex-wrapped row with readable full-widthNow:focus on desktop and390pxnarrow viewports) above multi-recipient delegations and equips each card header with Roster state ring, cleanScopepill,[step/3]pill, and single-lineNow:focus while preserving exact readback copy and single-<summary>accessibility.goal-workspace-work.tsx/goal-workspace-work.css): adds a horizontalsummaryOnlyRoster chip strip ([Ring] [label] [state] [done/total], interactive jump button +Scope/Now:tooltip) acrossBy owner,Board, andMaplenses so task rows andMapremain comfortably above the1280×800fold, plus enriched.goal-owner-groupheaders with Roster state badge,Scope,[done/total], and single-lineNow:.goal-agent-work-page.tsx/attached-agent-conversations.tsx/attached-agent-conversations.css): enriches.agent-work-directoryrows with Roster state badge,Scope,[done/total], andNow:while preserving exact single-button accessible names, and adds runtime/turn Roster badges +Scope+ non-duplicatingNow:(includeFallbackNow: falsewhen idle caption already explains status) toAttachedConversation.context-drawer.tsx): surfaces multi-worker Roster summary inside Goal details and sanitizedNow:+ Roster state/progress badges in Run summary views.First-Screen & Populated Visual Evidence (
1280×800&390×844)5789e163fbe1bc95c8f865f84e60c45172e1d2ee(rebased ontoorigin/main202d7bdb054b001cf002c3bdb83beb5012f21ccd); verified in Chromium Playwright over synthetic populated multi-worker fixtures (Needs decision,Working,Lease expired,Waiting, mixed long CN/EN titles, and raw JSON/ANSI telemetry noise) and packaged real backend smokes.origin/main)5789e163fb)1280×800390×8441280×8001280×800390×8441280×8001280×800scrollWidth == innerWidth,1280pxdesktop and390pxphone across all captured routes).summaryOnlychips wrap cleanly (2×2on desktop,.goal-owner-groupvisible aty = 657above the800pxdesktop fold acrossBy owner,Board, andMaplenses), whileCollaborationCards, owner headers,.agent-work-directory, and the Goal details drawer show full readableNow:focus lines without repeating idle captions.@media (prefers-reduced-motion: reduce)(animation: none) on spinning working rings and verified all tokens viacheck:css-custom-propertiesacrossloopx,paper, andbrutalthemes.Verification
npm --prefix apps/presentation/dashboard run check:css-custom-properties— passed (44stylesheets,3897bare references /1972 --pw-*,0undefined references)npm --prefix apps/presentation/dashboard run build(tsc --noEmit && vite build && npm run build:chat) — passednode --no-warnings --experimental-strip-types --test apps/presentation/dashboard/src/features/personal-workspace/*.test.mjs(collaboration-status.test.mjs,font-token.test.mjs,workspace-theme.test.mjs,personal-workspace-contract.test.mjs, plussmoke:agent-family,smoke:goal-work-browse,smoke:goal-order,smoke:goal-activity,smoke:proposal-recency) — all passedsmoke:multi-recipient— passed (recipient_count=2,automatic_return=true,additional_browser_writes=0)smoke/request-control-browser-smoke.mjs— passedLOOPX_PERSONAL_WORKSPACE_PACKAGED=1 smoke/goal-workspace-craft-browser-smoke.mjs— passed (390px&reduced-motionchecks passed)LOOPX_PERSONAL_WORKSPACE_PACKAGED=1 LOOPX_PERSONAL_WORKSPACE_SCENARIO=attached-host-follow-up— passedLOOPX_PERSONAL_WORKSPACE_PACKAGED=1 LOOPX_PERSONAL_WORKSPACE_SCENARIO=goal-workspace-m2— passed (200nodes,withinBudget: true)5789e163fbe1bc95c8f865f84e60c45172e1d2ee):personal-loopx-maintenance):cqr_38f9d820e61347e64d98(status: valid,receipt_state: valid,scope_fingerprint: 38f9d820e61347e64d98049aadba456fe525d68e567101548cd663ffe367dfbf)loopx canary premerge --from-git-diff --git-diff-base origin/main—4/4direct checks +5/5selected canaries passed (0failures)Boundary & Scope Checklist
apps/presentation/dashboard/src/features/personal-workspace/(12files; zero Python/core schema/backend edits)output/playwright/remains untracked/ignored)Signed-off-bytrailer